Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented May 2, 2025

Description

  • By default navigate to afterSignInUrl when a user clicks Continue within checkout complete component
  • Introduce __experimental_checkoutContinueUrl option that can override the afterSignInUrl navigation

Resolves COM-727

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: 7b2bc7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/tanstack-react-start Patch
@clerk/react-router Patch
@clerk/clerk-js Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/elements Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nuxt Patch
@clerk/shared Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2025 2:27am

@alexcarpenter
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @alexcarpenter - the snapshot version command generated the following package versions:

Package Version
@clerk/agent-toolkit 0.0.32-snapshot.v20250502201903
@clerk/astro 2.6.14-snapshot.v20250502201903
@clerk/backend 1.31.3-snapshot.v20250502201903
@clerk/chrome-extension 2.3.8-snapshot.v20250502201903
@clerk/clerk-js 5.63.6-snapshot.v20250502201903
@clerk/elements 0.23.23-snapshot.v20250502201903
@clerk/clerk-expo 2.10.8-snapshot.v20250502201903
@clerk/expo-passkeys 0.2.15-snapshot.v20250502201903
@clerk/express 1.4.15-snapshot.v20250502201903
@clerk/fastify 2.2.15-snapshot.v20250502201903
@clerk/localizations 3.14.5-snapshot.v20250502201903
@clerk/nextjs 6.18.6-snapshot.v20250502201903
@clerk/nuxt 1.6.1-snapshot.v20250502201903
@clerk/clerk-react 5.30.5-snapshot.v20250502201903
@clerk/react-router 1.3.6-snapshot.v20250502201903
@clerk/remix 4.6.6-snapshot.v20250502201903
@clerk/shared 3.7.9-snapshot.v20250502201903
@clerk/tanstack-react-start 0.14.6-snapshot.v20250502201903
@clerk/testing 1.6.5-snapshot.v20250502201903
@clerk/themes 2.2.41-snapshot.v20250502201903
@clerk/types 4.56.4-snapshot.v20250502201903
@clerk/vue 1.7.1-snapshot.v20250502201903

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/agent-toolkit@0.0.32-snapshot.v20250502201903 --save-exact

@clerk/astro

npm i @clerk/astro@2.6.14-snapshot.v20250502201903 --save-exact

@clerk/backend

npm i @clerk/backend@1.31.3-snapshot.v20250502201903 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.3.8-snapshot.v20250502201903 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.63.6-snapshot.v20250502201903 --save-exact

@clerk/elements

npm i @clerk/elements@0.23.23-snapshot.v20250502201903 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.10.8-snapshot.v20250502201903 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@0.2.15-snapshot.v20250502201903 --save-exact

@clerk/express

npm i @clerk/express@1.4.15-snapshot.v20250502201903 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.2.15-snapshot.v20250502201903 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.14.5-snapshot.v20250502201903 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.18.6-snapshot.v20250502201903 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.6.1-snapshot.v20250502201903 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.30.5-snapshot.v20250502201903 --save-exact

@clerk/react-router

npm i @clerk/react-router@1.3.6-snapshot.v20250502201903 --save-exact

@clerk/remix

npm i @clerk/remix@4.6.6-snapshot.v20250502201903 --save-exact

@clerk/shared

npm i @clerk/shared@3.7.9-snapshot.v20250502201903 --save-exact

@clerk/tanstack-react-start

npm i @clerk/tanstack-react-start@0.14.6-snapshot.v20250502201903 --save-exact

@clerk/testing

npm i @clerk/testing@1.6.5-snapshot.v20250502201903 --save-exact

@clerk/themes

npm i @clerk/themes@2.2.41-snapshot.v20250502201903 --save-exact

@clerk/types

npm i @clerk/types@4.56.4-snapshot.v20250502201903 --save-exact

@clerk/vue

npm i @clerk/vue@1.7.1-snapshot.v20250502201903 --save-exact

@alexcarpenter alexcarpenter requested review from aeliox and brkalow May 2, 2025 20:33
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I think it can be improved. If we merge before resolving the comments, let's follow up quickly after.

About the comments around experimental (if you agree) we should change the APIs before we merge since adding later would be breaking.

'@clerk/react-router': patch
'@clerk/clerk-js': patch
'@clerk/nextjs': patch
'@clerk/clerk-react': patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are missing Astro

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not merged #5774

@alexcarpenter alexcarpenter changed the title feat(clerk-js,types): Add checkoutContinueUrl option feat(clerk-js,types): Add __experiemental_checkoutContinueUrl option May 4, 2025
@brkalow brkalow enabled auto-merge (squash) May 5, 2025 02:21
@brkalow brkalow merged commit 037b113 into main May 5, 2025
32 checks passed
@brkalow brkalow deleted the alexcarpenter/com-727-continue-button-in-checkout-should-take-you-to-app-start branch May 5, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants