-
Notifications
You must be signed in to change notification settings - Fork 402
feat(clerk-js,types): Add __experiemental_checkoutContinueUrl option #5807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brkalow
merged 14 commits into
main
from
alexcarpenter/com-727-continue-button-in-checkout-should-take-you-to-app-start
May 5, 2025
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5fd35cd
feat(clerk-js,types): Add checkoutContinueUrl option
alexcarpenter 10cf2aa
Add changeset
alexcarpenter 6cc2427
merge
alexcarpenter f96e8c2
handle feedback
alexcarpenter 256b382
handle feedback
alexcarpenter 64189fa
Merge branch 'main' into alexcarpenter/com-727-continue-button-in-che…
alexcarpenter 5d6013f
fixes
alexcarpenter 56859aa
remove log
alexcarpenter 60be432
remove from useCheckout
brkalow 9d9b722
pnpm dedupe
brkalow cfb14c1
restore lockfile from main
brkalow 4080a36
do not navigate on checkout continue click in a modal setting
brkalow 5719f67
fix pnpm dedupe
brkalow 7b2bc7a
bundlewatch
brkalow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| '@clerk/tanstack-react-start': patch | ||
| '@clerk/react-router': patch | ||
| '@clerk/clerk-js': patch | ||
| '@clerk/nextjs': patch | ||
| '@clerk/clerk-react': patch | ||
| '@clerk/remix': patch | ||
| '@clerk/types': patch | ||
| --- | ||
|
|
||
| Introduce `checkoutContinueUrl` option. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,36 @@ | ||
| import { createContext, useContext } from 'react'; | ||
| import { useClerk } from '@clerk/shared/react'; | ||
| import { createContext, useContext, useMemo } from 'react'; | ||
|
|
||
| import type { __experimental_CheckoutCtx } from '../../types'; | ||
|
|
||
| export const __experimental_CheckoutContext = createContext<__experimental_CheckoutCtx | null>(null); | ||
|
|
||
| export const useCheckoutContext = () => { | ||
| const context = useContext(__experimental_CheckoutContext); | ||
| const clerk = useClerk(); | ||
|
|
||
| if (!context || context.componentName !== 'Checkout') { | ||
| throw new Error('Clerk: useCheckoutContext called outside Checkout.'); | ||
| } | ||
|
|
||
| const checkoutContinueUrl = useMemo(() => { | ||
| // When we're rendered via the PricingTable with mode = 'modal' we provide a `portalRoot` value | ||
| // we want to keep users within the context of the modal, so we do this to prevent navigating away | ||
| if (context.portalRoot) { | ||
| return undefined; | ||
| } | ||
|
|
||
| if (context.__experimental_checkoutContinueUrl) { | ||
| return context.__experimental_checkoutContinueUrl; | ||
| } | ||
|
|
||
| return clerk.__experimental_buildCheckoutContinueUrl?.(); | ||
| }, [context.portalRoot, context.__experimental_checkoutContinueUrl, clerk]); | ||
|
|
||
| const { componentName, ...ctx } = context; | ||
|
|
||
| return { | ||
| ...ctx, | ||
| componentName, | ||
| __experimental_checkoutContinueUrl: checkoutContinueUrl, | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are missing Astro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not merged #5774