-
Notifications
You must be signed in to change notification settings - Fork 402
fix(backend): Use paginated type response for API keys list method #7162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 88d0d63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1).changeset/**📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (25)
🔇 Additional comments (1)
Comment |
getSecret method and fix list method type|
!snapshot |
|
Hey @wobsoriano - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/agent-toolkit@0.1.47-snapshot.v20251105204110 --save-exact
npm i @clerk/astro@2.14.5-snapshot.v20251105204110 --save-exact
npm i @clerk/backend@2.19.4-snapshot.v20251105204110 --save-exact
npm i @clerk/chrome-extension@2.7.13-snapshot.v20251105204110 --save-exact
npm i @clerk/clerk-js@5.105.0-snapshot.v20251105204110 --save-exact
npm i @clerk/elements@0.23.78-snapshot.v20251105204110 --save-exact
npm i @clerk/clerk-expo@2.18.2-snapshot.v20251105204110 --save-exact
npm i @clerk/expo-passkeys@0.4.15-snapshot.v20251105204110 --save-exact
npm i @clerk/express@1.7.46-snapshot.v20251105204110 --save-exact
npm i @clerk/fastify@2.5.3-snapshot.v20251105204110 --save-exact
npm i @clerk/localizations@3.27.0-snapshot.v20251105204110 --save-exact
npm i @clerk/nextjs@6.34.4-snapshot.v20251105204110 --save-exact
npm i @clerk/nuxt@1.11.5-snapshot.v20251105204110 --save-exact
npm i @clerk/clerk-react@5.53.7-snapshot.v20251105204110 --save-exact
npm i @clerk/react-router@2.1.9-snapshot.v20251105204110 --save-exact
npm i @clerk/remix@4.13.12-snapshot.v20251105204110 --save-exact
npm i @clerk/shared@3.31.1-snapshot.v20251105204110 --save-exact
npm i @clerk/tanstack-react-start@0.26.8-snapshot.v20251105204110 --save-exact
npm i @clerk/testing@1.13.12-snapshot.v20251105204110 --save-exact
npm i @clerk/themes@2.4.33-snapshot.v20251105204110 --save-exact
npm i @clerk/types@4.97.2-snapshot.v20251105204110 --save-exact
npm i @clerk/vue@1.14.12-snapshot.v20251105204110 --save-exact |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@clerk/backend": minor | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing a minor since the data property is introduced in https://github.com/clerk/cloudflare-workers/pull/1378 and it was api_keys before.
api keys still in beta so still just a minor bump
|
Found 1 test failure on Blacksmith runners:
|
Description
Fixes incorrect return type for
clerkClient.apiKeys.list()Resolves USER-3879
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Breaking Changes
Documentation
Chores