-
Notifications
You must be signed in to change notification settings - Fork 402
fix(backend): Use paginated type response for API keys list method #7162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+15
−2
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bf7995a
fix(backend): Adjust api keys list method response type
wobsoriano 7e207c9
chore: remove getSecret method from api keys
wobsoriano 8bdc97b
chore: revert getSecret
wobsoriano 507f51d
chore: add changeset
wobsoriano b0cb851
chore: update changeset
wobsoriano 88d0d63
chore: update changeset
wobsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| "@clerk/backend": minor | ||
| --- | ||
|
|
||
| Fixed API keys `list` method return type | ||
|
|
||
| ```ts | ||
| const apiKeys = await clerkClient.apiKeys.list({ subject: 'user_xxxxx' }) | ||
|
|
||
| apiKeys.data | ||
| apiKeys.totalCount | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing a minor since the
dataproperty is introduced in https://github.com/clerk/cloudflare-workers/pull/1378 and it wasapi_keysbefore.api keys still in beta so still just a minor bump