Skip to content

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Nov 5, 2025

Description

Do not use jest ESLint rules in react package which uses vitest

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Broadened ESLint test config to apply across all packages (renamed vitest entry and expanded file glob).
    • Cleaned up lint suppression comments in multiple tests (no behavior changes).
    • Added a changeset file to record the update.

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

🦋 Changeset detected

Latest commit: 77d03ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Nov 6, 2025 2:17am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2025

Walkthrough

ESLint config broadened an exported vitest entry from packages/clerk-js tests to packages/* test globs; several test files had inline ESLint suppression or comments removed; a new empty changeset file was added.

Changes

Cohort / File(s) Change Summary
ESLint configuration
eslint.config.mjs
Renamed and broadened a vitest config entry: name changed from 'packages/clerk-js - vitest' to 'packages - vitest' and file glob from 'packages/clerk-js/src/**/*.test.{ts,tsx}' to 'packages/*/src/**/*.test.{ts,tsx}'.
React tests — linter comment removal
packages/react/src/hooks/__tests__/useAuth.test.tsx
Removed an inline // eslint-disable-next-line jest/unbound-method suppression comment before an assertion.
Chrome extension tests — comment / suppression cleanup
packages/chrome-extension/src/internal/utils/__tests__/cookies.test.ts, packages/chrome-extension/src/internal/utils/__tests__/storage.test.ts
Deleted inline comments and ESLint suppression comments (e.g., // eslint-disable-next-line jest/unbound-method) from tests; no logic changes.
Changeset
.changeset/great-cobras-give.md
Added a new changeset file containing placeholder content (---).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to eslint.config.mjs change to ensure the broadened glob and name match intended scopes.
  • Verify removed ESLint suppressions are appropriately covered by the new config for all affected test files.
  • Confirm the new changeset content meets release/process expectations.

Poem

🐰 I hopped through code with tidy paws,

Removed small notes and widened laws,
A config grown to cover more,
Tests now bloom across the floor,
Tiny changes, cheerful cause.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes removing jest eslint rules from @clerk/clerk-react, but the changeset actually affects the entire repo's ESLint configuration and multiple packages, not just the react package. Consider a more accurate title like 'chore(repo): Remove jest eslint rules and expand vitest ESLint config to all packages' to reflect the broader scope of changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-jest-rules-from-react

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 5, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7166

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7166

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7166

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7166

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7166

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7166

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7166

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7166

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7166

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7166

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7166

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7166

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7166

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7166

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7166

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7166

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7166

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7166

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7166

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7166

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7166

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7166

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7166

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7166

commit: 77d03ad

@blacksmith-sh
Copy link

blacksmith-sh bot commented Nov 5, 2025

Found 2 test failures on Blacksmith runners:

Test View Logs
[chrome] › integration/tests/
session-tasks-multi-session.test.ts:33:9 › session tasks multi-session flow @nextjs › l
ong-running--next.appRouter.withSessionTasks › when switching sessions, navigate to tas
k
View Logs
[setup] › integration/tests/
global.setup.ts:7:6 › start long running apps ─────────────────────
View Logs


Fix in Cursor

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4e09004 and 77d03ad.

📒 Files selected for processing (4)
  • .changeset/great-cobras-give.md (1 hunks)
  • eslint.config.mjs (1 hunks)
  • packages/chrome-extension/src/internal/utils/__tests__/cookies.test.ts (0 hunks)
  • packages/chrome-extension/src/internal/utils/__tests__/storage.test.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/chrome-extension/src/internal/utils/tests/storage.test.ts
  • packages/chrome-extension/src/internal/utils/tests/cookies.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • eslint.config.mjs
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/great-cobras-give.md
🪛 LanguageTool
.changeset/great-cobras-give.md

[grammar] ~1-~1: Hier könnte ein Fehler sein.
Context: --- ---

(QB_NEW_DE)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

@jacekradko jacekradko merged commit c81065f into main Nov 6, 2025
69 of 71 checks passed
@jacekradko jacekradko deleted the chore/remove-jest-rules-from-react branch November 6, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants