Skip to content

chore(repo): Remove jest eslint rules from @clerk/clerk-react #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

chore(repo): Remove jest eslint rules from @clerk/clerk-react #7166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e09004
chore(repo): Remove jest eslint rules from @clerk/clerk-react
jacekradko Nov 5, 2025
77d03ad
chore: empty changeset
jacekradko Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/great-cobras-give.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
4 changes: 2 additions & 2 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,8 @@ export default tseslint.config([
},
},
{
name: 'packages/clerk-js - vitest',
files: ['packages/clerk-js/src/**/*.test.{ts,tsx}'],
name: 'packages - vitest',
files: ['packages/*/src/**/*.test.{ts,tsx}'],
rules: {
'jest/unbound-method': 'off',
'@typescript-eslint/unbound-method': 'off',
Expand Down
1 change: 0 additions & 1 deletion packages/chrome-extension/src/internal/utils/__tests__/cookies.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ describe('Cookies', () => {
const name = '__client';
const cookie = createCookie({ name, value: 'foo', domain });

// eslint-disable-next-line jest/unbound-method -- The Jest ESLint plugin doesn't support Vitest
const getMock = vi.mocked(browser.cookies.get);

afterEach(() => getMock.mockReset());
Expand Down
4 changes: 0 additions & 4 deletions packages/chrome-extension/src/internal/utils/__tests__/storage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ describe('StorageCache', () => {

describe('set', () => {
test('setting the storage cache', async () => {
// eslint-disable-next-line jest/unbound-method -- The Jest ESLint plugin doesn't support Vitest
const setMock = vi.mocked(browser.storage.local.set).mockResolvedValueOnce(_void);

expect(await BrowserStorageCache.set(KEY, VALUE)).toBe(_void);
Expand All @@ -33,7 +32,6 @@ describe('StorageCache', () => {

describe('remove', () => {
test('removing from the storage cache', async () => {
// eslint-disable-next-line jest/unbound-method -- The Jest ESLint plugin doesn't support Vitest
const removeMock = vi.mocked(browser.storage.local.remove).mockResolvedValueOnce(_void);

expect(await BrowserStorageCache.remove(KEY)).toBe(_void);
Expand All @@ -48,7 +46,6 @@ describe('StorageCache', () => {
});

test('value missing', async () => {
// eslint-disable-next-line jest/unbound-method -- The Jest ESLint plugin doesn't support Vitest
const getMock = vi.mocked(browser.storage.local.get).mockResolvedValue({});

expect(await BrowserStorageCache.get(KEY)).toBeUndefined();
Expand All @@ -57,7 +54,6 @@ describe('StorageCache', () => {
});

test('value exists', async () => {
// eslint-disable-next-line jest/unbound-method -- The Jest ESLint plugin doesn't support Vitest
const getMock = vi.mocked(browser.storage.local.get).mockResolvedValue({ [KEY]: VALUE });

expect(await BrowserStorageCache.get(KEY)).toBe(VALUE);
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/hooks/__tests__/useAuth.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@ describe('useDerivedAuth', () => {
};
renderHook(() => useDerivedAuth(authObject));

// eslint-disable-next-line jest/unbound-method
expect(errorThrower.throw).toHaveBeenCalledWith(invalidStateError);
});

Expand Down
Loading