chore(expo): bump native SDK pins#8728
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 95d0ade The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
Break Check: no API changes detected across the tracked packages. |
📝 WalkthroughWalkthroughThis PR pins native SDK versions for Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/android/build.gradle`:
- Around line 21-22: ClerkAuthActivity.kt contains manual workarounds for
prepareVerification() and prepareSecondFactor() that may be unnecessary with
clerk-android-ui 1.0.22; review the behavior of prepareVerification() and
prepareSecondFactor() against the upstream 1.0.22 implementation and either
remove the workaround code in ClerkAuthActivity.kt or gate it behind a
runtime/compile-time check, referencing the workaround comments and the
prepareVerification()/prepareSecondFactor() methods to locate the code;
additionally add unit/integration tests covering sign-up email verification and
second-factor flows that assert the app calls or responds to
prepareVerification() and prepareSecondFactor() correctly with the 1.0.22 SDK to
prevent regressions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 1f5c9733-529d-49b0-b143-00a23d3c0c77
📒 Files selected for processing (4)
.changeset/expo-bump-clerk-android-1-0-18.md.changeset/expo-bump-native-sdks.mdpackages/expo/android/build.gradlepackages/expo/app.plugin.js
💤 Files with no reviewable changes (1)
- .changeset/expo-bump-clerk-android-1-0-18.md
wobsoriano
left a comment
There was a problem hiding this comment.
Can confirm native components work locally with provided snapshot 👍🏼
Summary
clerk-ios1.1.4clerk-android-apiandclerk-android-ui1.0.23