chore: pin puppeteer to a single version for GHA#3419
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate intermittent failures in the Publish Joint React Docs GitHub Action by ensuring only a single Puppeteer version is resolved, preventing concurrent Chromium downloads/installs during yarn install.
Changes:
- Adds a root-level Yarn
resolutionsoverride intended to forcegrunt-contrib-qunit’s Puppeteer dependency to usepuppeteer@24.22.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kumilingus
self-requested a review
July 7, 2026 16:25
kumilingus
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves an intermittent issue with the
publish-joint-react-docs.ymlGitHub Action caused bygrunt-contrib-qunit@7.0.1depending onpuppeteer@^19.7.0(which gets resolved as 19.11.1), which is different from the puppeteer everything else pulls in (24.22.0). This triggers a second download of Chrome.Yarn link step runs these two donwloads concurrently, causing a race condition between the 24.22.0 installer and the 19.11.1 installer. If the two installs overlap at the wrong instant, the action fails.
grunt-contrib-qunitjust needs a working puppeteer to drive headless QUnit, and its API (puppeteer.launch) is stable across 19→24 of Puppeteer.