Lua M2 §6: placement + format matrix cases

[clintecker]

Adds the untested filter branches by inspection (luacov can't measure filter coverage): figure wrap-outer/margin (outer {o} edge) + the \Needspace guard/width scaling with the measure and its fallback; set-pieces cascade/verse/tail degrading to a clean line block in plain-text (the non-web branch). New assertions only, behaviour unchanged. docs/LUA-QUALITY-PLAN.md §6.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NMBFSnRjob6Cmz1p4cwyCQ

Summary by CodeRabbit

• Tests
  • Added coverage to verify figure placement on outer edges and correct scaling across different measure widths.
  • Added integration coverage confirming cascade, verse, and tail render as clean Markdown line blocks without unwanted formatting artifacts.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request adds integration tests for figure placement and width scaling, plus a Pandoc test for clean Markdown rendering of cascade, verse, and tail.

Changes

Figure placement coverage

Layer / File(s)	Summary
Placement and width scaling tests tests/test_figure_placement.py	Tests cover outer-side wrap-outer and margin placement, measure-specific wrap widths, and \Needspace guards.

Set-piece rendering coverage

Layer / File(s)	Summary
Set-piece Markdown output test tests/test_set_pieces.py	The test verifies line-block output for cascade, verse, and tail without HTML classes, CSS indentation, LaTeX geometry, or PressVerse markup.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the test scope and unchanged behavior but omits the required Proof and Contract impact sections and a linked issue.	Add the required Proof and Contract impact sections, complete the evidence checklist, and provide a linked issue or state why none applies.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding Lua placement and format matrix tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch lua-m2-matrix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/test_set_pieces.py`:
- Around line 81-85: Update the set-piece test loop in tests/test_set_pieces.py
to map _CASCADE, _VERSE, and _TAIL to their expected markdown line sequences,
extract the rendered line-block content, and compare it exactly with the mapped
expectations. Preserve the existing artifact-negative assertions, including
checks for unlisted markup, while ensuring _VERSE’s empty stanza and all source
lines are validated.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5fc9dd45-91cb-4018-9dad-2be9b8e7fe7b

📥 Commits

Reviewing files that changed from the base of the PR and between 3c02ee5 and 703a334.

📒 Files selected for processing (2)

• tests/test_figure_placement.py
• tests/test_set_pieces.py

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Files matching test_set_pieces.py:\n'
fd -a 'test_set_pieces.py' . || true

file="$(fd 'test_set_pieces.py' . | head -n 1 || true)"
if [ -n "${file:-}" ]; then
  printf '\nStat:\n'
  wc -l "$file"
  printf '\nRelevant lines:\n'
  sed -n '1,140p' "$file" | nl -ba
fi

printf '\nSearch render/context identifiers:\n'
rg -n "_CASCADE|_VERSE|_TAIL|_render|test_|set_pieces" -S . || true

Repository: clintecker/press

Length of output: 328

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail
python3 - <<'PY'
from pathlib import Path
p = next(Path('.').rglob('test_set_pieces.py'), None)
print("path", p)
if p:
    txt=p.read_text()
    print("contains _CASCADE:", "_CASCADE" in txt)
PY

Repository: clintecker/press

Length of output: 208

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

file="tests/test_set_pieces.py"

printf 'tests/test_set_pieces.py:\n'
awk '{printf "%5d  %s\n", NR, $0}' "$file"

printf '\nSearch fixture/render definitions:\n'
rg -n "_CASCADE|_VERSE|_TAIL|_render|PressVerse|cascade|verse|tail|set_pieces|SetPiece|setpieces" -S . --glob '!*/.git/**' || true

Repository: clintecker/press

Length of output: 50372

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
from pathlib import Path

src = Path("tests/test_set_pieces.py").read_text()
def assert_pos(pattern, start=1):
    idx = src.find(pattern, start)
    print(f"{pattern!r}: {'FOUND at index ' + str(idx) if idx >= 0 else 'NOT FOUND'}")
    return idx

# Exact marker checks from the relevant assertions.
assert_pos("| ")
assert_pos('class="')
assert_pos('padding-left')
assert_pos('margin-left')
assert_pos('"wrapfigure"')
assert_pos('"\\hspace"')
assert_pos('"PressVerse"')

# Programmatic extraction of assertion bodies for tests around lines 76-85.
PY

python3 - <<'PY'
import ast
from pathlib import Path

tree = ast.parse(Path("tests/test_set_pieces.py").read_text())
for node in tree.body:
    if isinstance(node, ast.FunctionDef) and node.name == "test_constructs_degrade_to_a_clean_line_block_in_plaintext":
        print(ast.unparse(node))
PY

Repository: clintecker/press

Length of output: 793

---

Assert the expected markdown lines for each set-piece.

assert "| " in out only detects one line-block prefix and ignores missing source lines, _VERSE’s empty stanza, and unlisted markup. Map _CASCADE, _VERSE, and _TAIL to their expected line sequences and compare the extracted line-block content; keep the artifact-negative checks as additional guards.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/test_set_pieces.py` around lines 81 - 85, Update the set-piece test
loop in tests/test_set_pieces.py to map _CASCADE, _VERSE, and _TAIL to their
expected markdown line sequences, extract the rendered line-block content, and
compare it exactly with the mapped expectations. Preserve the existing
artifact-negative assertions, including checks for unlisted markup, while
ensuring _VERSE’s empty stanza and all source lines are validated.