Merge various changes (see description) into development - #179
Merged
markus-beuckelmann merged 6 commits intoJun 5, 2017
Conversation
Let's go back to BeautifulSoup version 3.2.1 for now. We will than at some point upgrade to BeautifulSoup 4 to have Python 3 compatibility. However, since we will have to use a parser like lxml, the parse tree might slightly change which will affect our tests and crawlers. Let's deal with this in separate commits.
Let's go back to BeautifulSoup version 3.2.1 for now. We will than at some point upgrade to BeautifulSoup 4 to have Python 3 compatibility. However, since we will have to use a parser like lxml, the parse tree might slightly change which will affect our tests and crawlers. Let's deal with this in separate commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will introduce the following changes:
BeautifulSoupv.3.2.1as opposed tov4. We will than at some point upgrade tov4to obtain Python 3 compatibility. However, since we will then have to use a parser likelxml, the parse tree might slightly change which will affect our tests and crawlers. Let's deal with this in separate commits.IndentationErrorbeing raised) inpattern.text.tests/return the correct status code (pass/fail) when called by e.g.python test/test_text.pypattern.web). This is mostly related to the services either being discontinued or deprecated (i.e. requiring some changes in the way we query/use their API).