Introduce some minor Python 3 changes - #180
Merged
Merged
Conversation
Ideally, it would be better to listen for ModuleNotFoundError instead of ImportError, but since this is only available in Python >= 3.6 let's stick to this for now.
In Python 2, we have to make use of the "new" module in the bind() function. In contrast, this is not necessary in Python 3 because we can directly assign the function to the object.
We should avoid catching ALL exceptions in this case since we only care about ImportError to distinguish between Python 2/3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will introduce some easy, minor changes working towards Python 3 support, affecting the unit tests,
pattern.web,pattern.server,pattern.db,pattern.graph,pattern.vector.