Adding AudioBlobCache - #73
Merged
Merged
Conversation
iambalaam
commented
Jul 29, 2026
iambalaam
commented
Contributor
- Adds a BlobCache that fetches data and stores as blobs
- Adds AudioBlobCache (thin wrapper) that prepares HTMLAudioElements
- Adds test suite and test server
- Currently unused, but will be piped into the rest of the MediaPreloader in the next PR
iambalaam
force-pushed
the
audio-blob-caching
branch
from
July 29, 2026 10:26
20c4dc4 to
09c7ae6
Compare
iambalaam
commented
Jul 29, 2026
| }; | ||
|
|
||
| describe('AudioBlobCache', () => { | ||
| beforeEach(() => cleanup()); |
Contributor
Author
There was a problem hiding this comment.
Just wanted to highlight the difference from our normal unit-test practise here.
For stateful / browser tests, it's much better to cleanup the state before the test than after.
chetbox
reviewed
Aug 4, 2026
chetbox
reviewed
Aug 4, 2026
chetbox
reviewed
Aug 4, 2026
chetbox
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.