Fix release flow#5579
Merged
Merged
Conversation
The release tag for a hotfix (e.g. v2.7.0-hotfix2) is passed straight through to the C# release, but `dotnet pack` derives the NuGet package version from the csproj <Version>, which is not bumped for a hotfix. So pack produces SpacetimeDB.*.2.7.0.nupkg while the publish step looked for ...2.7.0-hotfix2.nupkg and failed with "Package not found". Strip the -hotfix<N> suffix when building the NuGet package paths (and the summary output). We intentionally do not strip a generic prerelease suffix like -rc1, since those are baked into the csproj <Version> and are part of the real package version; only -hotfix is a tag-only concept. The Unity tag push keeps the full hotfix version. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
rekhoff
approved these changes
Jul 22, 2026
rekhoff
left a comment
rekhoff
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Does the apt update and strips out everything after the - so we don't get conflicts in environments that don't like -hotfix suffixes.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
API and ABI breaking changes
None
Expected complexity level and risk
1 - this is just a release change.
Testing