Skip to content

Fix rows of exactly 1024 bytes getting ignored in C# - #5621

Merged
clockwork-labs-bot merged 1 commit into
masterfrom
lisandro/fix-table-iter
Aug 5, 2026
Merged

Fix rows of exactly 1024 bytes getting ignored in C##5621
clockwork-labs-bot merged 1 commit into
masterfrom
lisandro/fix-table-iter

Conversation

@lisandroct

Copy link
Copy Markdown
Contributor

Description of Changes

In C#, a result of Errno.EXHAUSTED from row_iter_bsatn_advance was wrongly interpreted as "iterator is done, no bytes were written". This PR fixes it to match the contract correctly: EXHAUSTED: wrote zero or more bytes, and iterator is now done.

API and ABI breaking changes

No changes.

Expected complexity level and risk

  1. Trivial change.

Testing

  • Tested that 1024 bytes rows aren't ignored anymore

@JasonAtClockwork JasonAtClockwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonAtClockwork
JasonAtClockwork added this pull request to the merge queue Aug 4, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 4, 2026
@clockwork-labs-bot
clockwork-labs-bot added this pull request to the merge queue Aug 5, 2026
Merged via the queue into master with commit a2611b0 Aug 5, 2026
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants