CI - Fix npm dry run, and release dry runs actually testing the specified branch - #5636
Merged
Conversation
bfops
commented
Jul 31, 2026
bfops
commented
Jul 31, 2026
bfops
commented
Jul 31, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
commented
Jul 31, 2026
bfops
changed the title
jdetter
approved these changes
Jul 31, 2026
jdetter
left a comment
jdetter
left a comment
Contributor
There was a problem hiding this comment.
Lgtm, not manually tested by me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes #5635.
tl;dr it seems like newer versions of
npm publishactually check whether the package version is already published. This causes release dry runs to fail when they didn't before.Fixed by adding
--forceThis also fixes a bug in the release workflow, so that release dry runs check out the specific ref that the workflow is running from, rather than the release tag. Unfortunately these two independent fixes need to be bundled into a single PR, because neither can pass CI without the other right now.
Edit post-merge: I'm wrong; that second bugfix wasn't required to make this pass. I'm not sure why I got the CI failure I did originally, then.. but either way it's a good bugfix.
API and ABI breaking changes
none
Expected complexity level and risk
2
Testing