Skip to content

Split test_all_templates into individual smoketests - #5645

Merged
joshua-spacetime merged 3 commits into
masterfrom
joshua/ci/test_all_templates
Aug 3, 2026
Merged

Split test_all_templates into individual smoketests#5645
joshua-spacetime merged 3 commits into
masterfrom
joshua/ci/test_all_templates

Conversation

@joshua-spacetime

Copy link
Copy Markdown
Contributor

Description of Changes

This is part of the work to break up #5612 into smaller reviewable chunks.

During development and testing of #5612 (sharding the smoketest), I noticed that one shard consistently took longer to execute. This turned out to be whatever shard test_all_templates was assigned to. So this patch splits test_all_templates into 24 individual smoketests so that they can all be distributed evenly among shards.

In addition, I discovered there were quite a few rust modules that weren't being pre-compiled at all, so I've fixed that as well.

API and ABI breaking changes

None

Expected complexity level and risk

3 - A lot of AI assisted code motion. Mostly mechanical, but a large diff nonetheless.

Testing

All of the tests should continue to pass.

@joshua-spacetime
joshua-spacetime force-pushed the joshua/ci/test_all_templates branch from bf65804 to 932b84d Compare August 1, 2026 01:14
@joshua-spacetime
joshua-spacetime requested a review from gefjon August 1, 2026 01:15

@gefjon gefjon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't carefully validated that the new precompiled modules match the old inline definitions, so hopefully you haven't committed any copy-paste errors. Otherwise, looks good. It seems like we shouldn't have the interface that allows constructing a smoketest using a non-precompiled module; what's blocking us from removing that entirely?

Comment thread crates/smoketests/modules/Cargo.toml
@joshua-spacetime

Copy link
Copy Markdown
Contributor Author

It seems like we shouldn't have the interface that allows constructing a smoketest using a non-precompiled module; what's blocking us from removing that entirely?

There are smoketests that are specifically testing module compilation. cc @gefjon

@gefjon

gefjon commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

It seems like we shouldn't have the interface that allows constructing a smoketest using a non-precompiled module; what's blocking us from removing that entirely?

There are smoketests that are specifically testing module compilation. cc @gefjon

Surely that could be accomplished by explicitly calling spacetime build, right?

@joshua-spacetime
joshua-spacetime force-pushed the joshua/ci/test_all_templates branch from 932b84d to 41d6a72 Compare August 3, 2026 17:54
@joshua-spacetime
joshua-spacetime added this pull request to the merge queue Aug 3, 2026
Merged via the queue into master with commit 03e6113 Aug 3, 2026
84 of 96 checks passed
@joshua-spacetime
joshua-spacetime deleted the joshua/ci/test_all_templates branch August 3, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants