Replace gh run watch in workflow wrapper - #5689
Open
clockwork-labs-bot wants to merge 2 commits into
Open
Conversation
clockwork-labs-bot
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
August 7, 2026 17:50
bfops
reviewed
Aug 7, 2026
| run_id: u64, | ||
| run_url: Option<String>, | ||
| interval_seconds: u64, | ||
| max_attempts: u64, |
Collaborator
There was a problem hiding this comment.
make this optional. poll forever by default.
bfops
reviewed
Aug 7, 2026
| run_id: u64, | ||
| /// Optional URL printed while waiting for the run. | ||
| #[arg(long)] | ||
| run_url: Option<String>, |
Collaborator
There was a problem hiding this comment.
remove this. we can construct this from run_id and repo.
bfops
reviewed
Aug 7, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds
cargo ci other-workflows watch, a deterministic workflow-run watcher for CI wrappers. It pollsgh run view --json status,conclusion,url,jobsuntil the child run completes, prints a compact job summary, and exits from the final workflow conclusion.Updates the Internal Tests wrapper to use this command instead of
gh run watch.API and ABI breaking changes
None.
Expected complexity level and risk
Testing
cargo fmt -p ci -- --checkcargo check -p cicargo ci self-docs --checkcargo run -p ci -- other-workflows watch --help.github/workflows/internal-tests.ymlgit diff --check