Fix fn-transitive-deps to skip already-visited vars#389
Merged
Conversation
The checked set was accumulated but never used for filtering, so the same var could be expanded multiple times. Filter against checked instead of deps to avoid redundant fn-deps calls. Also simplified the cond to if since there are only two branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
checkedset infn-transitive-depswas accumulated but never used for filtering - new deps were filtered againstdepsinstead. This meant the same var could be expanded byfn-depsmultiple times in graphs with shared dependencies. Now filters againstcheckedto avoid redundant work.