Skip to content

Port CLJ-2954: disallow & as local #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swannodette merged 2 commits into from
Aug 9, 2026
+27 −2
Merged

Port CLJ-2954: disallow & as local #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a8e755
disallow & as local name
swannodette Aug 9, 2026
1cbdd32
compile time tests for disallowing & as local binding
swannodette Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/clojure/cljs/analyzer.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2510,13 +2510,14 @@ x (not (contains? ret :info)))
(loop [bes []
env (assoc encl-env :context :expr)
bindings (seq (partition 2 bindings))]

(if-some [[name init] (first bindings)]
(let []
(do
(when (or (some? (namespace name))
#?(:clj (.contains (str name) ".")
:cljs ^boolean (goog.string/contains (str name) ".")))
(throw (error encl-env (str "Invalid local name: " name))))
(when (= '& name)
(throw (error encl-env "Can't use & as a local binding")))
(let [init-expr (analyze-let-binding-init env init (cons {:params bes} *loop-lets*))
line (get-line name env)
col (get-col name env)
Expand Down
24 changes: 24 additions & 0 deletions src/test/clojure/cljs/compiler_tests.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,30 @@
(if (gobject/containsKey nil nil) true false)]))]
(is (nil? (re-find #"truth_" code))))))

(deftest test-amp-as-local-clj-2954
(testing "& disallowed as local binding"
(try
(env/with-compiler-env (env/default-compiler-env)
(compile-form-seq
'[(let [& 42] &)]))
(catch Throwable t
(is (instance? clojure.lang.ExceptionInfo t))
(is (.startsWith (-> t ex-cause ex-message) "Can't use & as a local binding"))))
(try
(env/with-compiler-env (env/default-compiler-env)
(compile-form-seq
'[(let* [& 42] &)]))
(catch Throwable t
(is (instance? clojure.lang.ExceptionInfo t))
(is (.startsWith (-> t ex-cause ex-message) "Can't use & as a local binding"))))
(try
(env/with-compiler-env (env/default-compiler-env)
(compile-form-seq
'[(loop* [& 42] &)]))
(catch Throwable t
(is (instance? clojure.lang.ExceptionInfo t))
(is (.startsWith (-> t ex-cause ex-message) "Can't use & as a local binding"))))))

;; CLJS-1225

(comment
Expand Down
Loading