You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
What's Changed
Bug Fixes
fix(logging): remove log-consumer task that closes transport (#1257): Commit 308d66f dropped enable_logging() from ServerCapabilities when upgrading to rmcp 1.8.0 (SEP-2577 removed MCP logging notifications). The on_initialized_impl log-consumer task was not removed and continued calling peer.send_notification(logging/message) on every tracing event. When the logging capability is not advertised, the transport worker's write to stdout fails on the first notification send, closing the stdout pipe and causing all subsequent tool calls to return -32603 Transport closed. analyze_file is the first tool that fires a tracing::debug! event on its cache-miss path, explaining the observed symptom. Fix: remove the log-consumer task entirely. The capability is not advertised, so the task serves no purpose. Log events accumulate in the unbounded channel and are dropped when the receiver is freed at session end; the sender silently ignores the closed-receiver error. Adds regression test transport_closed_after_tracing_event covering the exec_command path.