Add a block unit-test harness with @web/test-runner#14
Merged
Conversation
Introduce unit tests for the custom blocks, run in a real headless Chrome via @web/test-runner. No build step and no config file, matching how Adobe EDS projects test blocks. Cover the three interactive blocks: promo-bar, carousel, and perfect-fit. Each test builds the authored DOM, calls decorate(), and asserts on the result. Promo-bar collapse and expand, carousel navigation and wrap-around, and the perfect-fit modal open, close, and tab selection. CI runs the tests on every push, under xvfb, before the linters. Run locally with npm test. 18 tests, all passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13
Introduce a unit-test harness for block JavaScript.
The project had lint but no tests. This adds
@web/test-runnerwith@esm-bundle/chaiandsinon. Tests run in a real headless Chrome, sodecorate()and thescripts/aem.jshelpers it imports run for real. There is no build step and no config file, matching how Adobe EDS projects test blocks.Seed tests cover the three interactive blocks:
CI runs
npm teston every push, under xvfb, before the linters.Testing:
npm testruns 18 tests, all passing, in about 1 second.npm run lintpasses. No product code changed, so there is no page to preview for this PR.