fix: Add cryptsetup and modprobe dm-crypt to OS mount tool classes - #481
Merged
Merged
Conversation
cryptsetup is required to detect whether a device is LUKS-encrypted or not. It is now installed on the OS morphing minion. Now that cryptsetup is present in the OS morphing minion, the SSHCommandNotFoundException exception case is redundant. Additionally refines the exception case instead: we only return False if the command returns the exit code 1, and raise in any other case.
claudiubelu
force-pushed
the
update-luks-cryptsetup
branch
from
July 31, 2026 15:18
dafd6d9 to
9683e3e
Compare
Dany9966
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cryptsetupis required to detect whether a device is LUKS-encrypted or not. It is now installed on the OS morphing minion.Now that
cryptsetupis present in the OS morphing minion, theSSHCommandNotFoundExceptionexception case is redundant. Additionally refines the exception case instead: we only returnFalseif the command returns the exit code 1, and raise in any other case.