Add Ubuntu 26.04 support for OSMorphing minions - #486
Merged
Dany9966 merged 7 commits intoAug 10, 2026
Conversation
mihaelabalutoiu
force-pushed
the
add-ubuntu26-minion-support
branch
from
August 6, 2026 07:53
cb68090 to
f755f6e
Compare
Dany9966
requested changes
Aug 6, 2026
mihaelabalutoiu
force-pushed
the
add-ubuntu26-minion-support
branch
2 times, most recently
from
August 6, 2026 14:46
1614db9 to
57d1313
Compare
mihaelabalutoiu
marked this pull request as ready for review
August 6, 2026 15:26
Dany9966
requested changes
Aug 7, 2026
mihaelabalutoiu
force-pushed
the
add-ubuntu26-minion-support
branch
2 times, most recently
from
August 7, 2026 14:35
6d678e8 to
717c2b3
Compare
| '-o Dpkg::Options::=\'--force-confdef\'"' % ( | ||
| '-o Dpkg::Options::=--force-confdef' % ( | ||
| " ".join(package_names))) | ||
| self._environment['DEBIAN_FRONTEND'] = 'noninteractive' |
Member
There was a problem hiding this comment.
osmount tools set the DEBIAN_FRONTEND env variable as part of the setup call. The osmorphing tools do not have a setup method but I think we can move it to the __init__ method.
uninstall_packages needs it as well and it's cleaner to set this as part of the constructor as opposed to install_packages / uninstall_packages. Modifying the shared _environment field as a side effect here isn't a clean approach.
Member
Author
There was a problem hiding this comment.
Gotcha, I updated the code, moved it to the constructor, so it covers uninstall_packages too and the side effect is gone from install_packages. Please take a look now, thank you!
mihaelabalutoiu
force-pushed
the
add-ubuntu26-minion-support
branch
from
August 10, 2026 10:21
717c2b3 to
d5ca2ac
Compare
Dany9966
requested changes
Aug 10, 2026
`sudo-rs`, which is the default sudo on `Ubuntu 26.04`, does not implement the `-E` flag, so proxy variables no longer reached commands run inside the chroot. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
The OSMount setup commands relied on `sudo -E` to forward the proxy configuration to the package managers, which does not work on sudo implementations that do not support the flag. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
`set_grub_value` placed quotes by hand when building its sed scripts, so values containing spaces or quotes could be split into separate options instead of reaching sed as a single argument. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Env variables are passed to privileged and chrooted commands through `env(1)`, so a missing `env(1)` would surface as an unrelated failure partway through OSMorphing. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
The pty was needed for older minion images, but is no longer required, so set `get_pty` to `False` on all SSH commands. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Systemd uses shared mount propagation, allowing mounts created under `/proc`, `/sys`, `/dev` or `/run` on the minion to propagate into the OSMorphing chroot. On `Ubuntu 26.04` this can leave systemd credential mounts under `/run` busy and cause the final `umount -R` to fail with `target is busy`. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
add-ubuntu26-minion-support
branch
from
August 10, 2026 12:41
d5ca2ac to
b562652
Compare
Dany9966
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the following changes:
apt-getcommand;set_grub_valueplaced quotes by hand when building its sed scripts, so values containing spaces or quotes could be split into separate options instead of reaching sed as a single argument.sudo -Eto forward the proxy configuration to the package managers, which does not work onsudoimplementations that do not support the flag.sudo-rs, the default sudo on Ubuntu 26.04, does not implement the-Eflag, so proxy variables no longer reached commands run inside the chroot. They are now passed throughenv(1), whichchroot(1)preserves.envcommand availability check on OSMorphing hosts;ptyallocation for SSH commands/proc,/sys,/devor/runon the minion to propagate into the OSMorphing chroot./runbusy and cause the finalumount -Rto fail withtarget is busy.