Update _raise_response_error to raise a generic exception - #521
Merged
Conversation
fabi200123
changed the title
Previously the _raise_response_error was returning a Conflict exception that had the code 409. This created a bug, so that if the licence was supposed to return a 403 Not Authorized, the exception code was still 409, causing an issue. This commit changes the exception.Conflict to a generic exception, preserving the exception code received, rather than using 409 for all.
fabi200123
force-pushed
the
fix-bug-licensing
branch
from
September 8, 2026 15:19
89445fb to
c914707
Compare
Dany9966
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the _raise_response_error was returning a Conflict exception that had the code 409. This created a bug, so that if the licence was supposed to return a 403 Not Authorized, the exception code was still 409, causing an issue.
This commit changes the exception.Conflict to a generic exception, preserving the exception code received, rather than using 409 for all.