subset: relax validation rule #973

ono-max · 2025-01-26T23:34:25Z

Ruby team tries to use Zero Input Subsetting in the observation mode for their CI environment, but using both observation mode and Zero Input Subsetting are banned by CLI.

This validation rule has been introduced since https://github.com/launchableinc/cli/pull/435/files#diff-4c62e35fb4e3b2b6bff8593107cdddd1fd47eff90293edc9d838c9b2f3cff94aR138.

After discussion with @Konboi , we reached to the accord that we can relax the validation rule without any problems.

Summary by CodeRabbit

Bug Fixes
- Modified flag handling in subset command to remove previous restrictions on conflicting options
- Simplified option processing logic while maintaining core functionality

coderabbitai · 2025-01-26T23:34:33Z

Walkthrough

The pull request modifies the subset function in launchable/commands/subset.py by removing a conditional block that previously prevented simultaneous use of --observation and --get-tests-from-previous-sessions flags. This change allows the function to proceed without interruption when both flags are specified, potentially altering the command's behavior. The core functionality of the subset command remains largely intact, with other error handling mechanisms for prioritization flags still in place.

Changes

File	Change Summary
`launchable/commands/subset.py`	Removed conflicting options check for `--observation` and `--get-tests-from-previous-sessions` flags

Possibly related PRs

Introduce non-blocking mode in subset command #963: Modification of the subset function by adding a new --non-blocking command-line option, which similarly affects the function's control flow

Suggested reviewers

Konboi

Poem

🐰 A Rabbit's Subset Sonnet 🧪

Flags once conflicted, now set free to dance,
Options mingling without a second glance,
Subset command, with logic rearranged,
No more barriers, boundaries estranged!
Hop along, code, with newfound liberty! 🚀

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4cf5d63 and 61e5f39.

📒 Files selected for processing (1)

launchable/commands/subset.py (0 hunks)

💤 Files with no reviewable changes (1)

launchable/commands/subset.py

⏰ Context from checks skipped due to timeout of 90000ms (12)

GitHub Check: build (windows-latest, 3.12)
GitHub Check: build (windows-latest, 3.11)
GitHub Check: build (windows-latest, 3.10)
GitHub Check: build (windows-latest, 3.9)
GitHub Check: build (windows-latest, 3.8)
GitHub Check: build (windows-latest, 3.7)
GitHub Check: build (windows-latest, 3.6)
GitHub Check: build (ubuntu-20.04, 3.12)
GitHub Check: build (ubuntu-20.04, 3.9)
GitHub Check: build (ubuntu-20.04, 3.8)
GitHub Check: build (ubuntu-20.04, 3.7)
GitHub Check: build (ubuntu-20.04, 3.6)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-01-26T23:35:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Konboi · 2025-01-27T00:44:45Z

launchable/commands/subset.py

    app = context.obj
    tracking_client = TrackingClient(Tracking.Command.SUBSET, app=app)

-    if is_observation and is_get_tests_from_previous_sessions:


I gave it some thought, we should change this validation
from if is_observation and is_get_tests_from_previous_sessions: to if is_observation and is_output_exclusion_rules: to prevent miss integration.

We've already checked those condition at https://github.com/launchableinc/cli/blob/main/launchable/commands/subset.py#L235, don't we?

I didn't know that. Thanks

subset: relax validaiton rule

61e5f39

ono-max requested a review from Konboi January 26, 2025 23:34

Konboi reviewed Jan 27, 2025

View reviewed changes

Konboi approved these changes Jan 27, 2025

View reviewed changes

ono-max merged commit f11545f into main Jan 27, 2025
17 checks passed

ono-max deleted the relax-validation branch January 27, 2025 00:47

github-actions bot mentioned this pull request Jan 27, 2025

Release for v1.97.1 #974

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

subset: relax validation rule #973

subset: relax validation rule #973

Uh oh!

ono-max commented Jan 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 26, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

sonarqubecloud bot commented Jan 26, 2025

Uh oh!

Konboi Jan 27, 2025

Uh oh!

ono-max Jan 27, 2025

Uh oh!

Konboi Jan 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

subset: relax validation rule #973

subset: relax validation rule #973

Uh oh!

Conversation

ono-max commented Jan 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

sonarqubecloud bot commented Jan 26, 2025

Quality Gate passed

Uh oh!

Konboi Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

ono-max Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

Konboi Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ono-max commented Jan 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)