Get ready for building service config into serverless docker image#719
Merged
qiwzhang merged 4 commits intocloudendpoints:masterfrom Oct 22, 2019
Merged
Conversation
nareddyt
suggested changes
Oct 22, 2019
nareddyt
approved these changes
Oct 22, 2019
TAOXUY
approved these changes
Oct 22, 2019
JLXIA
reviewed
Oct 22, 2019
| FROM _SERVERLESS_IMAGE | ||
|
|
||
| ENV ENDPOINTS_SERVICE_PATH /etc/nginx/service.json | ||
| COPY service.json ${ENDPOINTS_SERVICE_PATH} |
Contributor
There was a problem hiding this comment.
Just curious, where this service.json is generated?
Contributor
Author
There was a problem hiding this comment.
Good question. I will have a separate PR to submit a shell script to use "gcloud" cli to download it and build the image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just to get ESP code ready for building service config into serverless image
Separate pr will check in a script for users to build the image