Merged
Conversation
… test (cloudendpoints#706)" This reverts commit 2605fc7. revert back to oauth2client since google-auth doesn't support python2.7 any more. ESP has to stay in python2.7
Contributor
Author
|
It passed pre-e2e test. https://endpoints-jenkins.appspot.com/job/jenkins-testing/job/pr-e2e/286/ |
nareddyt
approved these changes
Apr 22, 2020
|
|
||
| // Supported VM Images | ||
| SLAVE_IMAGE = 'gcr.io/endpoints-jenkins/debian-9:0.12' | ||
| SLAVE_IMAGE = 'gcr.io/endpoints-jenkins/debian-9:0.13' |
Contributor
There was a problem hiding this comment.
Why does this need to be updated?
Contributor
There was a problem hiding this comment.
Seems the environment installed in script/linux-install-software should be included in this image, which will be used in jenkins.
Contributor
Author
There was a problem hiding this comment.
Good question. My impression is jenkins slave image is specified here. But actually, it is in the jenkins endpoint config. Well, to be safe, also update it here.
TAOXUY
approved these changes
Apr 22, 2020
JLXIA
approved these changes
Apr 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As google-auth doesn't support python2.7 any more.
But ESP has to stay with python2.7 since its bazel stay at 0.21.