Skip to content

Comments

[api] Refactor task server private API endpoints#4076

Merged
Harshg999 merged 3 commits intomasterfrom
change-taskserver-apipath
Apr 1, 2025
Merged

[api] Refactor task server private API endpoints#4076
Harshg999 merged 3 commits intomasterfrom
change-taskserver-apipath

Conversation

@Harshg999
Copy link
Collaborator

@Harshg999 Harshg999 commented Mar 25, 2025

What changes were proposed in this pull request?

  • Change taskserver API endpoint URLs for consistency
  • Also introduce some request paramater handling because of above change.
  • This is required for the ad-hoc taskserver UI refactoring.

How was this patch tested?

  • Manually
  • Existing unit test suite.

@github-actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@Harshg999 Harshg999 changed the title [api] Change task server API endpoint signature for consistency [api] Refactor task server API endpoints for consistency Mar 25, 2025
@Harshg999 Harshg999 enabled auto-merge (squash) March 25, 2025 09:59
@Harshg999 Harshg999 disabled auto-merge March 25, 2025 09:59
@Harshg999 Harshg999 changed the title [api] Refactor task server API endpoints for consistency [api] Refactor task server private API endpoints for consistency Mar 25, 2025
@Harshg999 Harshg999 enabled auto-merge (squash) March 25, 2025 09:59
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

@Harshg999 Harshg999 changed the title [api] Refactor task server private API endpoints for consistency [api] Refactor task server private API endpoints Mar 25, 2025
@Harshg999 Harshg999 disabled auto-merge March 25, 2025 10:09
@Harshg999 Harshg999 enabled auto-merge (squash) March 25, 2025 10:10
Copy link
Collaborator

@ramprasadagarwal ramprasadagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for making the changes.

@Harshg999 Harshg999 disabled auto-merge March 25, 2025 10:30
@Harshg999 Harshg999 self-assigned this Mar 26, 2025
@Harshg999 Harshg999 force-pushed the change-taskserver-apipath branch from 79a3280 to 4a74480 Compare March 28, 2025 06:50
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

⚠️ No test files modified. Please ensure that changes are properly tested. ⚠️

@Harshg999 Harshg999 enabled auto-merge (squash) April 1, 2025 05:59
@Harshg999 Harshg999 merged commit adf189e into master Apr 1, 2025
7 of 8 checks passed
@Harshg999 Harshg999 deleted the change-taskserver-apipath branch April 1, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants