Skip to content

fix: correct TLS client ciphers field name - #32733

Open
ting-hong-shieh wants to merge 1 commit into
cloudflare:productionfrom
ting-hong-shieh:fix/tls-client-ciphers-field
Open

fix: correct TLS client ciphers field name#32733
ting-hong-shieh wants to merge 1 commit into
cloudflare:productionfrom
ting-hong-shieh:fix/tls-client-ciphers-field

Conversation

@ting-hong-shieh

Copy link
Copy Markdown

Summary

  • Rename cf.tls_ciphers_sha1 to the supported field name, cf.tls_client_ciphers_sha1.
  • Redirect the old generated reference URL to the corrected URL.

Closes #31014.

Validation

  • Confirmed that both Transform Rules field lists use cf.tls_client_ciphers_sha1.
  • Ran the docs Astro check across 441 files: 0 errors, warnings, or hints.
  • Built all 8,851 pages and confirmed that the corrected reference page and the 301 redirect are present in the output.

@ting-hong-shieh
ting-hong-shieh requested review from a team as code owners August 13, 2026 14:45
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit 1148b8b.

👉 Fix in your agent 👈
Fix the following review findings in PR #32733 (https://github.com/cloudflare/cloudflare-docs/pull/32733).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Warnings (1)

#### CR-97f852e03d39 · Redirect target page does not exist
- **File:** `public/__redirects` line 1648
- **Issue:** The redirect points to /ruleset-engine/rules-language/fields/reference/cf.tls_client_ciphers_sha1/, but src/content/fields/index.yaml still defines the field as cf.tls_ciphers_sha1 and has no cf.tls_client_ciphers_sha1 entry. Field reference pages are generated from src/content/fields/index.yaml, so the new URL will 404.
- **Fix:** Rename the field from cf.tls_ciphers_sha1 to cf.tls_client_ciphers_sha1 in src/content/fields/index.yaml so the redirect target resolves to a real page.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
public/__redirects line 1648 Redirect target page does not exist — The redirect points to /ruleset-engine/rules-language/fields/reference/cf.tls_client_ciphers_sha1/, but src/content/fields/index.yaml still defines the field as cf.tls_ciphers_sha1 and has no cf.tls_client_ciphers_sha1 entry. Field reference pages are generated from src/content/fields/index.yaml, so the new URL will 404. Fix: Rename the field from cf.tls_ciphers_sha1 to cf.tls_client_ciphers_sha1 in src/content/fields/index.yaml so the redirect target resolves to a real page.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cf.tls_ciphers_sha1 in Ruleset Engine Fields reference should be cf.tls_cilent_ciphers_sha1 instead

2 participants