Add support for IDN zone names in Punycode form#348
Merged
patryk merged 2 commits intocloudflare:masterfrom Oct 1, 2019
digineo:fix/347-punycode-zone
Merged
Add support for IDN zone names in Punycode form#348patryk merged 2 commits intocloudflare:masterfrom digineo:fix/347-punycode-zone
patryk merged 2 commits intocloudflare:masterfrom
digineo:fix/347-punycode-zone
Conversation
jacobbednarz
approved these changes
Sep 27, 2019
Contributor
jacobbednarz
left a comment
jacobbednarz
left a comment
There was a problem hiding this comment.
this looks great! thank you 🙏
Contributor
|
Let's just fix merge conflicts and it's good to go! |
Author
|
Sure, give me a moment :-) |
Author
|
I have rebased my changes onto master. |
corny
approved these changes
Sep 30, 2019
patryk
approved these changes
Oct 1, 2019
Author
|
@patryk: Thanks for merging!
|
|
We make cloudflare-go releases more or less as needed. If you need an urgent release, let me know. |
Michael9127
pushed a commit
to Michael9127/cloudflare-go
that referenced
this pull request
Oct 28, 2019
* Add support for IDN zone names in Punycode form fixes cloudflare#347 * vendor x/net/idna package
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #347. See there for details.
Has your change been tested?
Local tests pass. Integrating in lego succeeds.
Types of changes
What sort of change does your code introduce/modify?
Checklist: