Fix unmarshalling of OriginCACertificate#387
Merged
patryk merged 3 commits intocloudflare:masterfrom Dec 4, 2019
Merged
Conversation
Author
|
The other way to fix this is introduce a new type for just the field and modify the struct definition to type OriginCACertificate struct {
ExpiresOn certificateExpiresOn `json:"expires_on,omitempty"`That would remove the need to overload |
deuill
approved these changes
Dec 3, 2019
deuill
approved these changes
Dec 4, 2019
|
Thanks @player-two ! I have modified it slightly with help of the aliasing method described in http://choly.ca/post/go-json-marshalling/ |
8 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190
Description
The format of the
expires_onfield differs from what is documented, and the json parser makesCreateOriginCertificate()always return an error, even if the certificate was created. This change introduces custom timestamp parsing that works for both the actual and documented formats.Has your change been tested?
I wrote a tiny test program that calls
CreateOriginCertificate()and checked that the cert object is populated and the error isnil.Screenshots (if appropriate):
N/A
Types of changes
What sort of change does your code introduce/modify?
Checklist: