Skip to content

Add RevokedAt field to OriginCACertificate#392

Merged
patryk merged 2 commits intocloudflare:masterfrom
player-two:origin-ca-revoked-at
Dec 9, 2019
Merged

Add RevokedAt field to OriginCACertificate#392
patryk merged 2 commits intocloudflare:masterfrom
player-two:origin-ca-revoked-at

Conversation

@player-two
Copy link
Copy Markdown

@player-two player-two commented Dec 5, 2019

Description

Given a cert ID, I want to know if it has been revoked or not. The list call already filters out revoked certs, but that could require multiple calls to traverse pages when looking for the absence of an ID.

This field was originally added in #387 and pulled out (guessing unintentionally), which is fine because it wasn't very obvious nor related to the rest of that change.

Has your change been tested?

Just via a small script that prints the struct after revoking and re-fetching by the ID

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@patryk
Copy link
Copy Markdown

patryk commented Dec 9, 2019

Ops! I didn't notice you added new field, sorry!

@patryk patryk merged commit d285b33 into cloudflare:master Dec 9, 2019
@player-two
Copy link
Copy Markdown
Author

No problem at all!

@player-two player-two deleted the origin-ca-revoked-at branch December 9, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants