Add RevokedAt field to OriginCACertificate#392
Merged
patryk merged 2 commits intocloudflare:masterfrom Dec 9, 2019
Merged
Conversation
jacobbednarz
approved these changes
Dec 8, 2019
|
Ops! I didn't notice you added new field, sorry! |
patryk
approved these changes
Dec 9, 2019
Author
|
No problem at all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given a cert ID, I want to know if it has been revoked or not. The list call already filters out revoked certs, but that could require multiple calls to traverse pages when looking for the absence of an ID.
This field was originally added in #387 and pulled out (guessing unintentionally), which is fine because it wasn't very obvious nor related to the rest of that change.
Has your change been tested?
Just via a small script that prints the struct after revoking and re-fetching by the ID
Types of changes
What sort of change does your code introduce/modify?
Checklist: