ci: move continue-on-error from job level to step level#2723
Merged
Conversation
Job-level continue-on-error only prevents workflow failure but the job itself still reports as failed, which blocks PRs when the job is a required status check. Moving it to the step level makes the job conclude as success while still surfacing failures in the step output. Also re-enables detect-breaking-changes (was disabled with if: false) with step-level soft-fail so it runs but does not block. Refs: APIX-852
ssicard
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
continue-on-error: truefrom the job level to the step level ontestanddetect-breaking-changesjobs.Why: Job-level
continue-on-errorprevents the workflow from failing but the job itself still reports as failed. If the job is a required status check in branch protection, it still blocks the PR. Step-levelcontinue-on-errormakes the job conclude as success while the step output still shows the failure details.Changes
ci.yml: addedcontinue-on-error: trueto the "Run tests" stepdetect-breaking-changes.yml: re-enabled the job (was disabled withif: false), addedcontinue-on-error: trueto both the "Detect removed symbols" and "Detect breaking changes" stepsRefs: APIX-852