Skip to content

ci: move continue-on-error from job level to step level #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
musa-cf merged 1 commit into from
May 18, 2026
+3 −1
Merged

ci: move continue-on-error from job level to step level #2723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ jobs:
run: ./scripts/bootstrap

- name: Run tests
continue-on-error: true
run: ./scripts/test
env:
UV_PYTHON: ">=3.9.0"
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/detect-breaking-changes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ jobs:
detect_breaking_changes:
runs-on: 'ubuntu-latest'
name: detect-breaking-changes
if: false
permissions:
contents: read
steps:
Expand All @@ -29,10 +28,12 @@ jobs:
- name: Install dependencies
run: uv sync --all-extras
- name: Detect removed symbols
continue-on-error: true
run: |
uv run python scripts/detect-breaking-changes.py "${{ github.event.pull_request.base.sha }}"

- name: Detect breaking changes
continue-on-error: true
run: |
# Try to check out previous versions of the breaking change detection script. This ensures that
# we still detect breaking changes when entire files and their tests are removed.
Expand Down
Loading