build: migrate toolchain to Vite+ (vp) by TheAlexLichter · Pull Request #658 · cloudflare/kumo

TheAlexLichter · 2026-07-23T15:41:31Z

This is the first of a few PRs to move the repo over to Vite+.

What that means:

vp test/vp lint/vp fmt replacing vitest/oxlint/prettier
THe pnpm catalog aliases vite/vitest to the Vite+ packages
The three .oxlintrc.json files are merged into lint blocks in vite.config.ts
- Custom rules now import defineRule from @oxlint/plugins
- Native jsx-a11y rules are used instead of the JS plugin
Lefthook is replaced with vp's git hook management
Rewrites 91 vitest imports to vite-plus/test
Add temporary Prettier-parity fmt.ignorePatterns with upstream-issue links for ~10 files.
Make use-sync-external-store a real dependency (more accurate than bundling it)
Kumo is now built with Vite 8/Rolldown (this is the biggest "danger" for the user ⚠️)
- I did test the build but would appreciate a double check

Reviews
- bonk has reviewed the change
- automated review not possible because:
Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows: Running commands, checking outputs and testing built kumo
- Additional testing not necessary because: Matt did a thorough manual review.

TheAlexLichter · 2026-07-23T15:45:00Z

@@ -0,0 +1 @@
+/// <reference types="astro/client" />


Necessary so vp check understands the types used (usually auto generated but that is "too late")

TheAlexLichter · 2026-07-23T15:45:37Z

-    "baseUrl": ".",
    "paths": {
-      "~/*": ["src/*"]
+      "~/*": ["./src/*"]


Needed for TS7

TheAlexLichter · 2026-07-23T15:46:58Z

    "forceConsistentCasingInFileNames": true,
    "resolveJsonModule": true,
    "types": ["@figma/plugin-typings", "node"],
-    "baseUrl": ".",


Also needed for TS7 compat.

TheAlexLichter · 2026-07-23T15:50:57Z

@@ -0,0 +1 @@
+24.12.0


Added in addition to .nvmrc so previous tooling still works. This might cause drift in the future though.

TheAlexLichter · 2026-07-23T15:52:35Z

+  allowedVersions:
+    vite: "*"
+    vitest: "*"
+minimumReleaseAgeExclude:


We can remove these exceptions too.

TheAlexLichter · 2026-07-23T15:53:50Z

Added as "smoke test" to avoid interop issues

pkg-pr-new · 2026-07-23T15:59:50Z

npm i https://pkg.pr.new/@cloudflare/kumo@658

commit: 8733310

github-actions · 2026-07-23T16:01:14Z

Docs Preview

View docs preview

Commit: 8733310

github-actions · 2026-07-23T16:03:18Z

Visual Regression Report — 25 changed, 18 unchanged

25 screenshot(s) with visual changes:

Button / Loading State

33 px (0.04%) changed

Before	After	Diff

Dialog / Dialog With Actions

298 px (0.34%) changed

Before	After	Diff

Dialog / Dialog Basic

316 px (0.36%) changed

Before	After	Diff

Dialog / Dialog Sizes

2,945 px (3.33%) changed

Before	After	Diff

Dialog / Dialog Alert

433 px (0.49%) changed

Before	After	Diff

Dialog / Dialog Confirmation

440 px (0.5%) changed

Before	After	Diff

Dialog / Custom Max Width

951 px (1.07%) changed

Before	After	Diff

Dialog / Dialog With Dropdown

253 px (0.29%) changed

Before	After	Diff

Dialog (Open)

0 px (0%) changed

Before	After	Diff

Select / Select Basic

91 px (0.1%) changed

Before	After	Diff

Select / Select Sizes

3,098 px (1.91%) changed

Before	After	Diff

Select / Select Without Label

716 px (0.81%) changed

Before	After	Diff

Select / Select With Description

1,688 px (1.62%) changed

Before	After	Diff

Select / Select With Error

0 px (0%) changed

Before	After	Diff

Select / Select Placeholder

1,234 px (1.39%) changed

Before	After	Diff

Select / Select With Tooltip

933 px (1.05%) changed

Before	After	Diff

Select / Select Custom Rendering

1,137 px (1.28%) changed

Before	After	Diff

Select / Select Loading

3,161 px (1.79%) changed

Before	After	Diff

Select / Select Multiple

1,265 px (1.43%) changed

Before	After	Diff

Select / Select Complex

1,655 px (1.59%) changed

Before	After	Diff

Select / Select Disabled Items

793 px (0.9%) changed

Before	After	Diff

Select / Select Grouped

708 px (0.8%) changed

Before	After	Diff

Select / Select Grouped With Disabled

190 px (0.21%) changed

Before	After	Diff

Select / Select Long List

2,209 px (2.12%) changed

Before	After	Diff

Select (Open)

1,082 px (0%) changed

Before	After	Diff

18 screenshot(s) unchanged

Button / Basic
Button / Variant: Primary
Button / Variant: Secondary
Button / Variant: Ghost
Button / Variant: Destructive
Button / Variant: Outline
Button / Variant: Secondary Destructive
Button / Sizes
Button / With Icon
Button / Icon Only
Button / Disabled State
Button / Title
Button / Link as Button
Button / Link with Tooltip
Button / Disabled Link
Dialog / Dialog With Select
Dialog / Dialog With Combobox
Select / Select Disabled Options

Generated by Kumo Visual Regression

TheAlexLichter commented Jul 23, 2026

View reviewed changes

TheAlexLichter force-pushed the build/use-vite-plus branch 2 times, most recently from da2bb19 to 7728834 Compare July 23, 2026 15:50

TheAlexLichter commented Jul 23, 2026

View reviewed changes

TheAlexLichter added 2 commits July 23, 2026 18:02

build: migrate toolchain to Vite+ (vp)

6e191c6

refactor: rewrite vitest imports to vite-plus/test

8733310

TheAlexLichter force-pushed the build/use-vite-plus branch from 7728834 to 8733310 Compare July 23, 2026 16:03

mattrothenberg approved these changes Jul 23, 2026

View reviewed changes

mattrothenberg merged commit 8de0551 into cloudflare:main Jul 23, 2026
17 of 20 checks passed

TheAlexLichter deleted the build/use-vite-plus branch July 23, 2026 19:15

TheAlexLichter mentioned this pull request Jul 24, 2026

style: format remaining files with Oxfmt #659

Merged

5 tasks

fengmk2 mentioned this pull request Aug 4, 2026

feat(lint): serve the Oxlint plugin API from vite-plus voidzero-dev/vite-plus#2328

Draft

		@@ -0,0 +1 @@
		24.12.0

Uh oh!

Conversation

TheAlexLichter commented Jul 23, 2026 • edited by mattrothenberg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheAlexLichter Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

TheAlexLichter Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

TheAlexLichter Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

TheAlexLichter Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

TheAlexLichter Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

TheAlexLichter Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docs Preview

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Button / Loading State

Dialog / Dialog With Actions

Dialog / Dialog Basic

Dialog / Dialog Sizes

Dialog / Dialog Alert

Dialog / Dialog Confirmation

Dialog / Custom Max Width

Dialog / Dialog With Dropdown

Dialog (Open)

Select / Select Basic

Select / Select Sizes

Select / Select Without Label

Select / Select With Description

Select / Select With Error

Select / Select Placeholder

Select / Select With Tooltip

Select / Select Custom Rendering

Select / Select Loading

Select / Select Multiple

Select / Select Complex

Select / Select Disabled Items

Select / Select Grouped

Select / Select Grouped With Disabled

Select / Select Long List

Select (Open)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TheAlexLichter commented Jul 23, 2026 •

edited by mattrothenberg

Loading

pkg-pr-new Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading