fix(create): make create-vinext-app work with npm and npx - #2618
Conversation
commit: |
|
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
c320d34 to
ada84a9
Compare
|
/bonk review for issues |
|
APIError: Function tools with reasoning_effort are not supported for gpt-5.5 in /v1/chat/completions. To use function tools, use /v1/responses or set reasoning_effort to 'none'. |
|
@james-elicx Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
|
/bigbonk review for issues |
|
Both workflows are consistent. The Review SummaryI've completed a thorough review of PR #2618. No blocking issues found. The changes are correct, well-tested, and match Next.js/npm semantics. What I verified1. The npx fix (core change) — correct
2. The
3. The e2e-deploy.sh refactor — correct
4. CI workflow changes — correct and consistent
Verification run
Minor observations (non-blocking, no action required)
The PR does what it claims, fixes both root causes at the correct layer, and has adequate regression coverage. |
Summary
Root causes
The published creator only called its CLI when import.meta.url exactly matched process.argv[1]. npx launches package binaries through a node_modules/.bin symlink, while Node resolves import.meta.url to the real package file, so the comparison failed and the process exited successfully without doing anything.
Separately, @vinext/cloudflare published vinext >=0.0.0. npm semver excludes prereleases from that range, so an app explicitly using vinext 1.0.0-beta.x failed peer resolution. The workspace:^ source range is rewritten during packing to the matching prerelease range, currently ^1.0.0-beta.1, and will become ^1.0.0 for a stable release.
Validation