fix(app): authenticate static file signals - #3077
Merged
Merged
Conversation
Member
Author
|
/bigbonk review for issues You have a 7 minute limit for this review. Please prioritize concrete correctness, security, Next.js parity, and cross-runtime findings. |
commit: |
Contributor
|
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Contributor
|
LGTM! |
james-elicx
force-pushed
the
codex/fix-static-file-signal-smuggling
branch
from
August 25, 2026 09:04
c356f7b to
edc1ac9
Compare
Member
Author
|
/bigbonk review for issues Updated head removes the retired internal header constant entirely. You have a 7 minute limit for this review. Please prioritize concrete correctness, security, Next.js parity, and cross-runtime findings. |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-vinext-static-filevalues as ordinary response metadataWhy
Static asset routing was inferred from a response header that application route handlers could also return. A reflected or proxied value could therefore be mistaken for framework control flow and cause the host adapter to serve a different public asset.
The asset pathname now travels on a framework-created response capability instead of in HTTP headers. This matches Next.js filesystem-routing behavior while preserving custom application headers.
Validation
vp test run tests/request-pipeline.test.ts tests/app-rsc-handler.test.ts tests/app-rsc-response-finalizer.test.ts tests/deploy.test.tsvp checkvp run vinext#build