Skip to content

Make DOMException serializable/cloneable - #1876

Merged
jasnell merged 1 commit into
mainfrom
jsnell/domexception-cloneable
Apr 5, 2024
Merged

Make DOMException serializable/cloneable#1876
jasnell merged 1 commit into
mainfrom
jsnell/domexception-cloneable

Conversation

@jasnell

@jasnell jasnell commented Mar 21, 2024

Copy link
Copy Markdown
Collaborator

Makes DOMException cloneable for use with jsrpc and structuredClone()

@jasnell
jasnell requested review from dom96, kentonv and mikea March 21, 2024 20:02
@jasnell
jasnell requested review from a team as code owners March 21, 2024 20:02
@jasnell
jasnell marked this pull request as draft March 21, 2024 20:14
@jasnell

This comment was marked as resolved.

@jasnell
jasnell force-pushed the jsnell/domexception-cloneable branch from bf49a44 to 121d846 Compare March 21, 2024 20:22
@jasnell
jasnell marked this pull request as ready for review March 21, 2024 20:22

@fhanau fhanau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread src/workerd/jsg/dom-exception.h Outdated
Comment thread src/workerd/io/worker-interface.capnp
Comment thread src/workerd/jsg/dom-exception.h Outdated
kentonv
kentonv previously approved these changes Apr 1, 2024
Comment thread src/workerd/jsg/dom-exception.c++
@kentonv
kentonv dismissed their stale review April 1, 2024 20:46

Let's figure out the duplication of message.

@jasnell
jasnell force-pushed the jsnell/domexception-cloneable branch from 121d846 to 61ea01e Compare April 4, 2024 16:38
@jasnell
jasnell force-pushed the jsnell/domexception-cloneable branch from 61ea01e to 32b1ca3 Compare April 5, 2024 20:28
@jasnell
jasnell merged commit 789638f into main Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants