Account for external memory usage internal streams - #2185
Merged
Conversation
jasnell
requested review from
a-robinson,
byule,
fhanau,
harrishancock and
jp4a50
May 29, 2024 14:54
jasnell
commented
May 29, 2024
jasnell
marked this pull request as draft
May 29, 2024 16:51
Switching using an v8::ArrayBuffer rather than a raw v8::BackingStore will ensure that the external memory is actively tracked by the isolate while the read is pending.
jasnell
force-pushed
the
jsnell/streams-adjust-external-memory
branch
from
May 30, 2024 16:56
05fbc20 to
306ecf7
Compare
jasnell
changed the title
jasnell
marked this pull request as ready for review
May 30, 2024 16:57
Collaborator
Author
|
Ok, this is ready for review. I've limited this PR to only touch the |
a-robinson
removed their request for review
May 30, 2024 17:54
jp4a50
approved these changes
May 30, 2024
| byteLength = errorCase ? 0 : UnderlyingSource::DEFAULT_AUTO_ALLOCATE_CHUNK_SIZE; | ||
| store = v8::ArrayBuffer::NewBackingStore(js.v8Isolate, byteLength); | ||
|
|
||
| if (!v8::ArrayBuffer::MaybeNew(js.v8Isolate, byteLength).ToLocal(&store)) { |
Collaborator
Author
There was a problem hiding this comment.
If I'm following the link there correctly, this one is actually allocating new space, the other is just wrapping around the existing allocation.
Contributor
There was a problem hiding this comment.
Ah, of course, so the one that wraps an existing allocation can't fail which is why it's New and not MaybeNew. Makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes improve the account for external memory usage in internal readable and writable streams. JS-backed streams will be handled in a separate PR.
When a
v8::BackingStoreis detached from thev8::ArrayBuffer, it is no longer accounted for in the external memory reporting for a given isolate. Here we implement manual adjustments for both pending read into buffers and enqueued data.