Revert "Revert "Disable slow tests by default"" - #2208
Merged
garrettgu10 merged 3 commits intoJun 4, 2024
Conversation
garrettgu10
force-pushed
the
revert-2207-revert-2205-ggu/disable-slow-tests-by-default
branch
from
June 3, 2024 18:21
ec23efd to
391df37
Compare
garrettgu10
marked this pull request as ready for review
June 3, 2024 21:09
Contributor
Author
|
This works upstream, safe to merge (well, along with the upstream PR) |
hoodmane
approved these changes
Jun 3, 2024
jasnell
approved these changes
Jun 3, 2024
Contributor
|
Neither of these files should have any effect on upstream (it has its own bazelrc and CI setup), so yeah this should be plenty safe. |
Contributor
Author
|
Hold on, i think this conflicts with another change that just merged, needs a rebase |
fhanau
approved these changes
Jun 4, 2024
garrettgu10
force-pushed
the
revert-2207-revert-2205-ggu/disable-slow-tests-by-default
branch
from
June 4, 2024 14:38
a3eea34 to
2739d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2207