Conversation
|
The changes are clean, complete, and consistent. Let me verify one more thing - whether the The switch statement in The TypeScript type union in This is a minimal, well-structured addition of a new enum variant across all the right layers. No behavioral changes, no backward compatibility concerns (additive only), no security implications. LGTM |
Merging this PR will not alter performance
Comparing Footnotes
|
7053e41 to
fd0dcf8
Compare
e6c3d59 to
48b0783
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6589 +/- ##
=======================================
Coverage 66.47% 66.48%
=======================================
Files 405 405
Lines 117773 117775 +2
Branches 19424 19425 +1
=======================================
+ Hits 78295 78297 +2
+ Misses 27900 27898 -2
- Partials 11578 11580 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
48b0783 to
d615a50
Compare
See internal discussion as for the rationale for this.
As noted in outcome.capnp, the authoritative version of EventOutcome is defined internally and needs to be updated first – this has already been done.
Note that internalError is not being used in workerd at present – we likely will use it in server.c++'s RequestObserverWithTracer::reportFailure(), but we should only start using it there once we've finalized how it will be used in the edge runtime.
Also see the internal PR.