Skip to content

[o11y] Add internalError event outcome #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhanau merged 1 commit into from
Apr 22, 2026
Merged

[o11y] Add internalError event outcome #6589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/workerd/io/outcome.capnp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@ enum EventOutcome {
exceededMemory @8;
loadShed @9;
responseStreamDisconnected @10;
internalError @11;
}
3 changes: 3 additions & 0 deletions src/workerd/io/trace-stream.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ namespace {
V(HIBERNATABLEWEBSOCKET, "hibernatableWebSocket") \
V(ID, "id") \
V(INFO, "info") \
V(INTERNALERROR, "internalError") \
V(INVOCATIONID, "invocationId") \
V(JSRPC, "jsrpc") \
V(KILLSWITCH, "killSwitch") \
Expand Down Expand Up @@ -329,6 +330,8 @@ jsg::JsValue ToJs(jsg::Lock& js, const EventOutcome& outcome, StringCache& cache
return cache.get(js, RESPONSESTREAMDISCONNECTED_STR);
case EventOutcome::SCRIPT_NOT_FOUND:
return cache.get(js, SCRIPTNOTFOUND_STR);
case EventOutcome::INTERNAL_ERROR:
return cache.get(js, INTERNALERROR_STR);
case EventOutcome::UNKNOWN:
return cache.get(js, UNKNOWN_STR);
}
Expand Down
2 changes: 1 addition & 1 deletion types/defines/trace.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ interface ConnectEventInfo {

type EventOutcome = "ok" | "canceled" | "exception" | "unknown" | "killSwitch" |
"daemonDown" | "exceededCpu" | "exceededMemory" | "loadShed" |
"responseStreamDisconnected" | "scriptNotFound";
"responseStreamDisconnected" | "scriptNotFound" | "internalError";

interface ScriptVersion {
readonly id: string;
Expand Down
3 changes: 2 additions & 1 deletion types/generated-snapshot/experimental/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15315,7 +15315,8 @@ declare namespace TailStream {
| "exceededMemory"
| "loadShed"
| "responseStreamDisconnected"
| "scriptNotFound";
| "scriptNotFound"
| "internalError";
interface ScriptVersion {
readonly id: string;
readonly tag?: string;
Expand Down
3 changes: 2 additions & 1 deletion types/generated-snapshot/experimental/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15276,7 +15276,8 @@ export declare namespace TailStream {
| "exceededMemory"
| "loadShed"
| "responseStreamDisconnected"
| "scriptNotFound";
| "scriptNotFound"
| "internalError";
interface ScriptVersion {
readonly id: string;
readonly tag?: string;
Expand Down
3 changes: 2 additions & 1 deletion types/generated-snapshot/latest/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14655,7 +14655,8 @@ declare namespace TailStream {
| "exceededMemory"
| "loadShed"
| "responseStreamDisconnected"
| "scriptNotFound";
| "scriptNotFound"
| "internalError";
interface ScriptVersion {
readonly id: string;
readonly tag?: string;
Expand Down
3 changes: 2 additions & 1 deletion types/generated-snapshot/latest/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14616,7 +14616,8 @@ export declare namespace TailStream {
| "exceededMemory"
| "loadShed"
| "responseStreamDisconnected"
| "scriptNotFound";
| "scriptNotFound"
| "internalError";
interface ScriptVersion {
readonly id: string;
readonly tag?: string;
Expand Down
Loading