Deprecate ensureReplicas/disableReplicas.

[jtolio]

In cases where typescript annotations mention the old methods, we should explain what is replacing them.

Once #6649 is merged this PR should be retargeted to main.

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

This PR adds @deprecated annotations for ensureReplicas() and disableReplicas() on DurableObjectStorage, pointing users to configureReadReplication() instead.

Issue: @deprecated tags are inside plain comments, not JSDoc comments — TypeScript will not recognize them.

The annotation strings start with a space (` @deprecated...`), which causes ts.addSyntheticLeadingComment to emit /* @deprecated ... */ (plain comment). TypeScript only processes @deprecated tags inside /** */ (JSDoc) comments. Users will not see strikethrough in their IDEs.

The fix is to prefix the strings with * instead of a space, producing /** @deprecated ... */. The pre-existing primary entry has the same bug.

---

This review was generated by an AI assistant and may contain inaccuracies.

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

This PR adds @deprecated annotations for ensureReplicas() and disableReplicas() on DurableObjectStorage, pointing users to configureReadReplication() instead.

One issue found: The @deprecated tags are inside plain comments (/* */) instead of JSDoc comments (/** */). TypeScript only recognizes @deprecated inside JSDoc comments, so users won't see strikethrough in their IDEs. The fix is to change the annotation strings in types/src/cloudflare.ts to start with * instead of a space. I posted a suggestion comment with the fix (which also fixes the pre-existing bug on the primary entry).

github run

[codspeed-hq]

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks¹

---

_{Comparing jolio/deprecate-ensureReplicas (2d45197) with jolio/move-config-read-replication (3a820d2)}

Footnotes

1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.50%. Comparing base (3a820d2) to head (2d45197).

Additional details and impacted files

@@                         Coverage Diff                         @@
##           jolio/move-config-read-replication    #6638   +/-   ##
===================================================================
  Coverage                               66.50%   66.50%           
===================================================================
  Files                                     405      405           
  Lines                                  115976   115976           
  Branches                                19409    19409           
===================================================================
  Hits                                    77133    77133           
  Misses                                  27265    27265           
  Partials                                11578    11578           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[justin-mp]

Note that you don't actually need to base this on top of the other branch, as it doesn't depend on that branch for anything. You could rebase on top of main and it would apply just fine!

[jtolio]

Rebase and retarget branch

[jtolio]

Note that you don't actually need to base this on top of the other branch, as it doesn't depend on that branch for anything. You could rebase on top of main and it would apply just fine!

Logically it's not dependent, but sadly it is syntactically/git conflict dependent, due to either this or the change below it adding a new stanza to types/src/cloudflare.ts