Move experimental configureReadReplication from ctx.storage to ctx.#6649
Move experimental configureReadReplication from ctx.storage to ctx.#6649
Conversation
|
This PR is clean. Let me summarize my analysis:
LGTM |
Merging this PR will not alter performance
Comparing Footnotes
|
2ae88e3 to
f86c757
Compare
f86c757 to
2684b54
Compare
950bce5 to
d668e2b
Compare
5c04e43 to
4e7ffab
Compare
d668e2b to
0649f75
Compare
Before read replication becomes generally available, make the API more friendly by moving configureReadReplication up. Logically, read replication is more a property of the DO itself than the storage subsystem. X-Dest-Branch: jolio/move-config-read-replication
4e7ffab to
82d96dc
Compare
0649f75 to
3a820d2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jolio/add-ctx-primaryStub #6649 +/- ##
============================================================
Coverage ? 66.50%
============================================================
Files ? 405
Lines ? 115976
Branches ? 19409
============================================================
Hits ? 77133
Misses ? 27265
Partials ? 11578 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Before read replication becomes generally available, make the API more friendly by moving configureReadReplication up. Logically, read replication is more a property of the DO itself than the storage subsystem.
Should be retargeted at main once #6663 is merged