Use jsg::JsArrayBufferView and remove cached length/offset in byob options - #6932
Open
jasnell wants to merge 2 commits into
Open
Use jsg::JsArrayBufferView and remove cached length/offset in byob options#6932jasnell wants to merge 2 commits into
jasnell wants to merge 2 commits into
Conversation
Contributor
|
LGTM |
jasnell
force-pushed
the
jasnell/byob-use-jsarraybufferview
branch
from
August 7, 2026 20:28
d51ceca to
c1fffc5
Compare
This comment was marked as low quality.
This comment was marked as low quality.
…tions The `ByobOptions` were using a cache length/offset making it risky when resizable/transfered ArrayBuffers were used. Harden it more by not caching the length/offset and switching to JsArrayBufferView Signed-off-by: James M Snell <jsnell@cloudflare.com>
jasnell
force-pushed
the
jasnell/byob-use-jsarraybufferview
branch
from
August 7, 2026 23:09
c1fffc5 to
8bf8672
Compare
Appears to be related to a test harness / sidecar issue to investigate. Only flaking on mac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tions
The
ByobOptionswere using a cache length/offset making it risky when resizable/transfered ArrayBuffers were used. Harden it more by not caching the length/offset and switching to JsArrayBufferView