Skip to content

Update WPT and ada-url - #6944

Merged
npaun merged 1 commit into
mainfrom
npaun/wpt-2026-july
Aug 10, 2026
Merged

Update WPT and ada-url#6944
npaun merged 1 commit into
mainfrom
npaun/wpt-2026-july

Conversation

@npaun

@npaun npaun commented Aug 10, 2026

Copy link
Copy Markdown
Member

Update WPT to 1985b47aa and ada-url to 4.0.0, then align the test configurations and in-house URL cases with their new behavior.

Refresh renamed and newly added WPT coverage, including WebCrypto serialization tests, and remove stale malformed-Punycode suppressions.

Update WPT to 1985b47aa and ada-url to 4.0.0, then align the
test configurations and in-house URL cases with their new behavior.

Refresh renamed and newly added WPT coverage, including WebCrypto
serialization tests, and remove stale malformed-Punycode suppressions.
@npaun
npaun requested review from a team as code owners August 10, 2026 14:05
@npaun
npaun requested review from a team and jasnell August 10, 2026 14:05

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Bonk, and I've done a quick review of your PR.

This PR updates ada-url to 4.0.0 and WPT to 1985b47aa, then aligns test configurations with the new upstream behavior: Punycode labels now parse as valid URLs, renamed tests are tracked, removed tests are dropped, and new test coverage (WebCrypto serialization, fetch textStream, etc.) is added.

One minor issue found.


This review was generated by an AI assistant and may contain inaccuracies.

Comment thread src/wpt/encoding-test-ts.ts
@ask-bonk

ask-bonk Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

This PR updates ada-url to 4.0.0 and WPT to 1985b47aa, then aligns test configurations with the new upstream behavior: Punycode labels now parse as valid URLs, renamed tests are tracked, removed tests are dropped, and new test coverage (WebCrypto serialization, fetch textStream, etc.) is added.

One minor issue found:

  1. [LOW] src/wpt/encoding-test-ts.ts:95 -- The comment for single-byte-decoder.any.js says "document and XMLHttpRequest are not supported," but the .any.js variant shouldn't contain document-dependent tests (those live in the new -iframe.window.js entry). The C++ variant in encoding-test.ts handles this same test more precisely with expectedFailures: [/\(XMLHttpRequest\)$/] instead of blanket-disabling. Posted as an inline suggestion.

github run

@fhanau fhanau mentioned this pull request Aug 10, 2026
@npaun

npaun commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

Merging for now. @jasnell will check the test config changes later when he has time

@npaun
npaun merged commit 634b69a into main Aug 10, 2026
39 of 40 checks passed
@npaun
npaun deleted the npaun/wpt-2026-july branch August 10, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants