src: fix container-client textExec test - #6964
Open
flakey5 wants to merge 2 commits into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
|
APIError: Invalid Anthropic API Key |
2 similar comments
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
@flakey5 Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
flakey5
force-pushed
the
flakey5/20260809/container-tests
branch
from
August 10, 2026 22:29
faa4d56 to
74906d6
Compare
jasnell
reviewed
Aug 11, 2026
Comment on lines
+28
to
+31
| assert.throws(() => { | ||
| throw err; | ||
| }, expected); | ||
| return; |
Collaborator
There was a problem hiding this comment.
This looks... odd... it's not clear exactly what you're doing here. it's worth more of a comment.
Collaborator
There was a problem hiding this comment.
Ah, wait, I reread it... it just looks ... weird. you might be able to use assert.rejects(Promise.try(fn), expected) ?
jasnell
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.