Skip to content

Tag SQLite errors with SENTRY_DO - #7150

Merged
jtolio merged 2 commits into
mainfrom
jolio/tag-sqlite-e-3ybjsg
Sep 4, 2026
Merged

Tag SQLite errors with SENTRY_DO#7150
jtolio merged 2 commits into
mainfrom
jolio/tag-sqlite-e-3ybjsg

Conversation

@jtolio

@jtolio jtolio commented Aug 27, 2026

Copy link
Copy Markdown
Member

Prefix existing SQLite open and VFS exception descriptions so they are routed to the Durable Objects Sentry project without changing exception control flow.

@jtolio
jtolio requested review from a team as code owners August 27, 2026 20:19
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from 2dfa4cf to cf5f0bf Compare August 27, 2026 20:20
@ask-bonk

ask-bonk Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from cf5f0bf to 76f670b Compare August 27, 2026 20:23
Comment thread src/workerd/util/sqlite-test.c++
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from ca279c0 to 701b3b2 Compare August 28, 2026 15:34
@jtolio
jtolio requested a review from shrima-cf August 28, 2026 15:59
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from 701b3b2 to 86520ca Compare August 29, 2026 03:57
@jtolio
jtolio changed the base branch from main to jolio/instrument-l-lziro4 August 29, 2026 04:00
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from 86520ca to bc9a0fb Compare August 29, 2026 04:06
@codecov-commenter

codecov-commenter commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.34%. Comparing base (7726c8e) to head (5844f17).

Files with missing lines Patch % Lines
src/workerd/util/sqlite-test.c++ 84.21% 0 Missing and 3 partials ⚠️
src/workerd/io/actor-sqlite-test.c++ 0.00% 0 Missing and 1 partial ⚠️
src/workerd/util/sqlite.c++ 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7150   +/-   ##
=======================================
  Coverage   37.34%   37.34%           
=======================================
  Files         803      803           
  Lines      251595   251624   +29     
  Branches    20009    20013    +4     
=======================================
+ Hits        93954    93970   +16     
- Misses     146260   146266    +6     
- Partials    11381    11388    +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch 2 times, most recently from a72e25a to e98d7d5 Compare September 1, 2026 16:34
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from e98d7d5 to 547449b Compare September 3, 2026 03:08
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch 2 times, most recently from cecb495 to 6590202 Compare September 3, 2026 21:47
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from 6590202 to b759788 Compare September 4, 2026 02:55
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from b759788 to 9f54bae Compare September 4, 2026 09:58
Base automatically changed from jolio/instrument-l-lziro4 to main September 4, 2026 10:53
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch 2 times, most recently from e8b56e7 to ab1bd10 Compare September 4, 2026 11:19
Prefix existing SQLite open and VFS exception descriptions so they
are routed to the Durable Objects Sentry project without changing
exception handling control flow.
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from ab1bd10 to 5844f17 Compare September 4, 2026 14:50
@jtolio
jtolio merged commit 6f5cf2e into main Sep 4, 2026
21 of 22 checks passed
@jtolio
jtolio deleted the jolio/tag-sqlite-e-3ybjsg branch September 4, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants