Enable perfetto in workerd v8 build - #7223
Conversation
|
@jasnell Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
|
That looks cleaner than I thought! Two suggestions:
|
since we're already building with perfetto enabled (and using it in prod) enabling this in v8 adds at most roughly 0.227% to the file size. If we want, we want disable for opt/release builds but that's something we can easily do as a separate PR I think. |
a000c43 to
59a2651
Compare
@fhanau ... not sure what you mean. |
v8_flag() is a macro used in V8's BUILD.bazel to configure V8 defines and make them easy to turn on/off. If we want to upstream this patch, that's probably the right approach to use for consistency with other defines. An LLM should be able to do it if you feed it my prior comment. |
59a2651 to
c422c44
Compare
npaun
left a comment
There was a problem hiding this comment.
Reviewed this cause I like to keep up with our build changes
0ff7930 to
722bd2e
Compare
722bd2e to
e9f785b
Compare
Patches v8's bazel build to allow building v8 with perfetto enabled.
Also, add perfetto traces for per-isolate boostrap.